linux-kernel - Re: [PATCH v3] ALSA: line6: add hw monitor volume control for POD HD500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr1tfzzgf.wl-tiwai@suse.de>
Date:   Mon, 13 Jul 2020 08:44:16 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Vasily Khoruzhick <anarsoul@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Pavel Machek <pavel@...x.de>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ALSA: line6: add hw monitor volume control for POD HD500

On Mon, 13 Jul 2020 07:46:35 +0200,
Vasily Khoruzhick wrote:
> 
> Add hw monitor volume control for POD HD500. The same change may
> work for HD500X but I don't have it to test.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@...il.com>
> ---
> v3: - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL
>     - use GFP_KERNEL instead of GFP_ATOMIC for allocating a message
>     - use lower case for float lookup table
> v2: clamp volume value to [0, ARRAY_SIZE() -1] in
>     podhd_set_monitor_level()

Almost good, but just a minor issue below:


> +static void podhd_set_monitor_level(struct usb_line6_podhd *podhd, int value)
> +{
(snip)
> +	buf = kmalloc(sizeof(msg), GFP_KERNEL);
> +	memcpy(buf, msg, sizeof(msg));

Missing NULL check of buf.

Could you fix and resubmit?


Thanks!

Takashi