lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 13 Jul 2020 09:58:01 +0300
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     linux-nvdimm@...ts.01.org, Jia He <justin.he@....com>,
        Will Deacon <will@...nel.org>,
        David Hildenbrand <david@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        peterz@...radead.org, vishal.l.verma@...el.com,
        dave.hansen@...ux.intel.com, ard.biesheuvel@...aro.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, hch@....de, joao.m.martins@...cle.com
Subject: Re: [PATCH v2 07/22] numa: Introduce a generic
 memory_add_physaddr_to_nid()

Hi Dan,

On Sun, Jul 12, 2020 at 09:26:43AM -0700, Dan Williams wrote:
> For architectures that opt into storing their numa data in memblock
> (only ARM64 currently), add a memblock generic way to interrogate that
> data for memory_add_physaddr_to_nid(). This requires ARCH_KEEP_MEMBLOCK
> to keep memblock text and data around after boot.

I afraid we are too far from using memblock as a generic placeholder for
numa data. Although all architectures now have the numa info in
memblock, only arm64 uses memblock as the primary source of that data.

I'd rather prefer Jia's solution [1] to have a weak default for
memory_add_physaddr_to_nid() and let architectures override it.

[1] https://lore.kernel.org/lkml/20200710031619.18762-2-justin.he@arm.com

> Cc: Mike Rapoport <rppt@...ux.ibm.com>
> Cc: Jia He <justin.he@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
> ---
>  include/linux/mm.h |   11 +++++++++++
>  mm/Kconfig         |    6 ++++++
>  mm/page_alloc.c    |   23 ++++++++++++++++++++++-
>  3 files changed, 39 insertions(+), 1 deletion(-)
> 

-- 
Sincerely yours,
Mike.

Powered by blists - more mailing lists