linux-kernel - Re: [PATCH v10 04/15] perf evlist: introduce control file descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <823145dc-f293-166e-290b-076c1254fe17@linux.intel.com>
Date:   Mon, 13 Jul 2020 11:16:06 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 04/15] perf evlist: introduce control file descriptors


On 13.07.2020 6:13, Namhyung Kim wrote:
> Hello,
> 
> On Wed, Jul 8, 2020 at 4:47 PM Alexey Budankov
> <alexey.budankov@...ux.intel.com> wrote:
>>
>>
>> Define and initialize control file descriptors.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@...ux.intel.com>
>> ---
>>  tools/perf/util/evlist.c | 3 +++
>>  tools/perf/util/evlist.h | 5 +++++
>>  2 files changed, 8 insertions(+)
>>
>> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
>> index bcbe0cb8482e..36eb50aba1f5 100644
>> --- a/tools/perf/util/evlist.c
>> +++ b/tools/perf/util/evlist.c
>> @@ -63,6 +63,9 @@ void evlist__init(struct evlist *evlist, struct perf_cpu_map *cpus,
>>         perf_evlist__set_maps(&evlist->core, cpus, threads);
>>         evlist->workload.pid = -1;
>>         evlist->bkw_mmap_state = BKW_MMAP_NOTREADY;
>> +       evlist->ctl_fd.fd = -1;
>> +       evlist->ctl_fd.ack = -1;
>> +       evlist->ctl_fd.pos = -1;
>>  }
>>
>>  struct evlist *evlist__new(void)
>> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
>> index 38901c0d1599..2caf19fb87a8 100644
>> --- a/tools/perf/util/evlist.h
>> +++ b/tools/perf/util/evlist.h
>> @@ -74,6 +74,11 @@ struct evlist {
>>                 pthread_t               th;
>>                 volatile int            done;
>>         } thread;
>> +       struct {
>> +               int     fd;
>> +               int     ack;
>> +               int     pos;
>> +       } ctl_fd;
> 
> Could you please add brief descriptions for each field
> in the comment?  It's not obvious to me other than fd.

Ok. In v11.

Alexei