linux-kernel - Re: [PATCH] Input: break joystick limitation of maximum 80 buttons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713090653.GB3703480@smile.fi.intel.com>
Date:   Mon, 13 Jul 2020 12:06:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wei Shuai <cpuwolf@...il.com>
Cc:     "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." 
        <linux-input@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Borislav Petkov <bp@...e.de>, Mattias Jacobsson <2pi@....nu>,
        Mark Gross <mgross@...ux.intel.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Erwan Velu <e.velu@...teo.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: break joystick limitation of maximum 80 buttons

On Sun, Jul 12, 2020 at 07:54:54AM +0800, Wei Shuai wrote:
> The joystick max buttons 80 limitation comes from
> 
> #define BTN_JOYSTICK 0x120
> #define BTN_DEAD 0x12f
> #define BTN_TRIGGER_HAPPY 0x2c0
> #define KEY_MAX 0x2ff
> 
> include/uapi/linux/input-event-codes.h
> 
> according to function hidinput_configure_usage() in file drivers/hid/hid-input.c
> 
> the joystick button mapping is not a continues space
> generally speaking, the mapping space is from
> 
> 1. BTN_JOYSTICK~BTN_DEAD
> 2. BTN_TRIGGER_HAPPY~KEY_MAX
> 
> Finally, I got the max limitation is 80.
> The patch is expanding KEY_MAX from 0x2ff to 4ff
> and the change has been verified on 104 button USB HID device on Ubuntu


If you send and resend this patch too often, nobody will take you seriously.
Also, you have to provide versioning and changelog in each submission.
Besides that, above doesn't answer to question "why?". Why are you doing this
at all? What the problem?


-- 
With Best Regards,
Andy Shevchenko