linux-kernel - Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABHD4K-JdzcNa2YqH2KnVtVQrjoaVp+Y0L6F1jJNm2iN-pJ3=A@mail.gmail.com>
Date:   Mon, 13 Jul 2020 14:38:55 +0530
From:   Amit Tomer <amittomer25@...il.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Andre Przywara <andre.przywara@....com>,
        Andreas Färber <afaerber@...e.de>,
        Rob Herring <robh+dt@...nel.org>, cristian.ciocaltea@...il.com,
        linux-kernel@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-actions@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7

Hi,

> Fixed regulators are used to nicely model the regulators which aren't tied to
> any PMIC. But for some cases we use them to represent supplies when there is
> no support for the specific PMIC present in the kernel and they are turned
> on/configured by the bootloader (this is what happening here).
>
> And there is no use of declaring fixed regulators when there is no consumer.
> Even if you don't define these, the corresponding supplies in the board will
> always be in the same state configured by the bootloader. So I'd suggest you
> to remove this for now.

Checked the schematics and regulator name is the same for both eMMC and uSD
Shall we keep uSD regulator sd_vcc to be consistent across ACTIONS platform?

> Since I don't have the schematics to check, please make sure you name the
> regulators as mentioned in the schematics (this could vary from board to board,
> so don't just copy from others).
>

Sure, point noted.

Thanks
-Amit.