linux-kernel - RE: [PATCH v4] 9p: retrieve fid from file when file instance exist.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR0802MB2555EB19FCA15EB3B14F50BAF4600@HE1PR0802MB2555.eurprd08.prod.outlook.com>
Date:   Mon, 13 Jul 2020 09:27:07 +0000
From:   Jianyong Wu <Jianyong.Wu@....com>
To:     Dominique Martinet <asmadeus@...ewreck.org>
CC:     "ericvh@...il.com" <ericvh@...il.com>,
        "lucho@...kov.net" <lucho@...kov.net>,
        "v9fs-developer@...ts.sourceforge.net" 
        <v9fs-developer@...ts.sourceforge.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Steve Capper <Steve.Capper@....com>,
        Kaly Xin <Kaly.Xin@....com>, Justin He <Justin.He@....com>,
        Wei Chen <Wei.Chen@....com>
Subject: RE: [PATCH v4] 9p: retrieve fid from file when file instance exist.



> -----Original Message-----
> From: Dominique Martinet <asmadeus@...ewreck.org>
> Sent: Friday, July 10, 2020 7:09 PM
> To: Jianyong Wu <Jianyong.Wu@....com>
> Cc: ericvh@...il.com; lucho@...kov.net; v9fs-
> developer@...ts.sourceforge.net; linux-kernel@...r.kernel.org; Steve
> Capper <Steve.Capper@....com>; Kaly Xin <Kaly.Xin@....com>; Justin He
> <Justin.He@....com>; Wei Chen <Wei.Chen@....com>
> Subject: Re: [PATCH v4] 9p: retrieve fid from file when file instance exist.
>
> Jianyong Wu wrote on Fri, Jul 10, 2020:
> > In the current setattr implementation in 9p, fid is always retrieved
> > from dentry no matter file instance exists or not. If so, there may be
> > some info related to opened file instance dropped. So it's better to
> > retrieve fid from file instance when it is passed to setattr.
> >
> > for example:
> > fd=open("tmp", O_RDWR);
> > ftruncate(fd, 10);
> >
> > The file context related with the fd will be lost as fid is always
> > retrieved from dentry, then the backend can't get the info of file
> > context. It is against the original intention of user and may lead to
> > bug.
> >
> > Signed-off-by: Jianyong Wu <jianyong.wu@....com>
> > ---
>
>
> For next time, you can add arbitrary comments (e.g. describe briefly
> differences from previous versions) after the --- line.
>
> For others, this inits fid to NULL in both functions; thanks for picking it up I'll
> refresh the patch.
>
Ok,

Thanks
Jianyong
> --
> Dominique
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.