linux-kernel - Re: [PATCH] Staging: vc04_services: Fix code indent error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Jul 2020 16:38:21 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Baidyanath Kundu <kundubaidya99@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] Staging: vc04_services: Fix code indent error

On Mon, Jul 13, 2020 at 03:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> > This patch fixes the checkpatch.pl error:
> > 
> > ERROR: code indent should use tabs where possible
> > 
> > Signed-off-by: Baidyanath Kundu <kundubaidya99@...il.com>
> > ---
> >  .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c  | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index a075cd63da7f..86c00b68f099 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> >  	/* queue the bulk submission */
> >  	vchiq_use_service(instance->service_handle);
> >  	ret = vchiq_bulk_receive(instance->service_handle,
> > -				 msg_context->u.bulk.buffer->buffer,
> > -			         /* Actual receive needs to be a multiple
> > -			          * of 4 bytes
> > -			          */
> > -			         (len + 3) & ~3,
> > -			         msg_context,
> > -			         VCHIQ_BULK_MODE_CALLBACK);
> > +				msg_context->u.bulk.buffer->buffer,
> > +				/* Actual receive needs to be a multiple
> > +				 * of 4 bytes
> > +				 */
> > +				(len + 3) & ~3,
> > +				msg_context,
> > +				VCHIQ_BULK_MODE_CALLBACK);
> 
> Close, you need one more space for these lines, right?
> 

Yeah.  The original has the space and looks correct.

regards,
dan carpenter