linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad50a2a7-0b06-420e-baa7-dec2787ab30d@linux.ibm.com>
Date:   Mon, 13 Jul 2020 09:28:32 -0500
From:   Eddie James <eajames@...ux.ibm.com>
To:     Pavel Machek <pavel@....cz>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org, dmurphy@...com,
        jacek.anaszewski@...il.com, vishwa@...ux.ibm.com
Subject: Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation
 compatible string


On 7/11/20 8:48 AM, Pavel Machek wrote:
> Hi!
>
>> IBM created an implementation of the PCA9552 on a PIC16F
>> microcontroller. Document the new compatible string for this device.
> Is the implementation opensource?


Hi, no it is not.


>
>> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
>> +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt
>> @@ -9,6 +9,7 @@ Required properties:
>>   	"nxp,pca9550"
>>   	"nxp,pca9551"
>>   	"nxp,pca9552"
>> +	"nxp,pca9552-ibm"
>>   	"nxp,pca9553"
> Is it good idea to use nxp prefix for something that is
> software-defined and not built by nxp?


Yea I suppose not...

>
> Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that
> is not real hardware, but software emulation?


How about ibm,pca9552-sw? Someone suggested that just adding "sw" could 
be a problem if another company does the same thing but it isn't compatible.


Thanks for taking a look!

Eddie


>
> Best regards,
> 									Pavel