linux-kernel - Re: [PATCH] imx: Provide correct number of resources when registering gpio devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200713030232.GA21277@dragon>
Date:   Mon, 13 Jul 2020 11:02:33 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Russell King <linux@...linux.org.uk>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] imx: Provide correct number of resources when
 registering gpio devices

On Tue, Jun 30, 2020 at 08:26:51PM -0700, Guenter Roeck wrote:
> Since commit a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is
> invalid"), the kernel is a bit touchy when it encounters interrupt 0.
> As a result, there are lots of warnings such as the following when booting
> systems such as 'kzm'.
> 
> WARNING: CPU: 0 PID: 1 at drivers/base/platform.c:224 platform_get_irq_optional+0x118/0x128
> 0 is an invalid IRQ number
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3 #1
> Hardware name: Kyoto Microcomputer Co., Ltd. KZM-ARM11-01
> [<c01127d4>] (unwind_backtrace) from [<c010c620>] (show_stack+0x10/0x14)
> [<c010c620>] (show_stack) from [<c06f5f54>] (dump_stack+0xe8/0x120)
> [<c06f5f54>] (dump_stack) from [<c0128878>] (__warn+0xe4/0x108)
> [<c0128878>] (__warn) from [<c0128910>] (warn_slowpath_fmt+0x74/0xbc)
> [<c0128910>] (warn_slowpath_fmt) from [<c08b8e84>] (platform_get_irq_optional+0x118/0x128)
> [<c08b8e84>] (platform_get_irq_optional) from [<c08b8eb4>] (platform_irq_count+0x20/0x3c)
> [<c08b8eb4>] (platform_irq_count) from [<c0728660>] (mxc_gpio_probe+0x8c/0x494)
> [<c0728660>] (mxc_gpio_probe) from [<c08b93cc>] (platform_drv_probe+0x48/0x98)
> [<c08b93cc>] (platform_drv_probe) from [<c08b703c>] (really_probe+0x214/0x344)
> [<c08b703c>] (really_probe) from [<c08b7274>] (driver_probe_device+0x58/0xb4)
> [<c08b7274>] (driver_probe_device) from [<c08b7478>] (device_driver_attach+0x58/0x60)
> [<c08b7478>] (device_driver_attach) from [<c08b7504>] (__driver_attach+0x84/0xc0)
> [<c08b7504>] (__driver_attach) from [<c08b50f8>] (bus_for_each_dev+0x78/0xb8)
> [<c08b50f8>] (bus_for_each_dev) from [<c08b62cc>] (bus_add_driver+0x154/0x1e0)
> [<c08b62cc>] (bus_add_driver) from [<c08b82b8>] (driver_register+0x74/0x108)
> [<c08b82b8>] (driver_register) from [<c0102320>] (do_one_initcall+0x80/0x3b4)
> [<c0102320>] (do_one_initcall) from [<c1501008>] (kernel_init_freeable+0x170/0x208)
> [<c1501008>] (kernel_init_freeable) from [<c0e178d4>] (kernel_init+0x8/0x11c)
> [<c0e178d4>] (kernel_init) from [<c0100134>] (ret_from_fork+0x14/0x20)
> 
> As it turns out, mxc_register_gpio() is a bit lax when setting the
> number of resources: it registers a resource with interrupt 0 when in
> reality there is no such interrupt. Fix the problem by not declaring
> the second interrupt resource if there is no second interrupt.
> 
> Fixes: a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is invalid")
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

I changed the subject prefix to 'ARM: imx: ...' and applied the patch.

Shawn