linux-kernel - Re: [PATCH] USB: serial: sierra: clean up special-interface handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713155127.GA267581@kroah.com>
Date:   Mon, 13 Jul 2020 17:51:27 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: sierra: clean up special-interface handling

On Mon, Jul 13, 2020 at 05:39:36PM +0200, Johan Hovold wrote:
> Clean up the handling of special interfaces that either should be
> ignored or that need a larger number of URBs.
> 
> Commit 66f092ed3b94 ("USB: serial: sierra: unify quirk handling logic")
> replaced the previous is_blacklisted() and is_highmemory() helpers with
> a single is_quirk() helper which made it even harder to understand what
> the interface lists were used for.
> 
> Rename the interface-list struct, its members and the interface-lookup
> helper and restructure the code somewhat in order to make it more
> self-explanatory.

Much better, that was messy, thanks for cleaning this up.

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>