| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Jul 2020 22:35:27 +0800
From: kernel test robot <lkp@...el.com>
To: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, Catalin Marinas <catalin.marinas@....com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Paul Mackerras <paulus@...ba.org>,
Zong Li <zong.li@...ive.com>, Andi Kleen <ak@...ux.intel.com>,
Paul Burton <paulburton@...nel.org>,
Vincent Whitchurch <vincent.whitchurch@...s.com>,
Petr Mladek <pmladek@...e.com>, Brian Gerst <brgerst@...il.com>
Subject: Re: [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and
move to kernel proper
Hi Jarkko,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.8-rc5]
[cannot apply to tip/perf/core tip/x86/core jeyu/modules-next next-20200714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/kprobes-Remove-MODULE-dependency/20200714-184220
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 0dc589da873b58b70f4caf4b070fb0cf70fdd1dc
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:19,
from arch/riscv/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from arch/riscv/kernel/text.c:6:
arch/riscv/kernel/text.c: In function 'text_alloc':
>> arch/riscv/kernel/text.c:12:33: error: '_end' undeclared (first use in this function); did you mean 'va_end'?
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~~
include/linux/kernel.h:851:22: note: in definition of macro '__typecheck'
851 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^
include/linux/kernel.h:875:24: note: in expansion of macro '__safe_cmp'
875 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
include/linux/kernel.h:891:19: note: in expansion of macro '__careful_cmp'
891 | #define max(x, y) __careful_cmp(x, y, >)
| ^~~~~~~~~~~~~
arch/riscv/kernel/text.c:12:3: note: in expansion of macro 'max'
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~
arch/riscv/kernel/text.c:12:7: note: in expansion of macro 'PFN_ALIGN'
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~~~~~~~
arch/riscv/kernel/text.c:15:39: note: in expansion of macro 'VMALLOC_MODULE_START'
15 | return __vmalloc_node_range(size, 1, VMALLOC_MODULE_START,
| ^~~~~~~~~~~~~~~~~~~~
arch/riscv/kernel/text.c:12:33: note: each undeclared identifier is reported only once for each function it appears in
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~~
include/linux/kernel.h:851:22: note: in definition of macro '__typecheck'
851 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^
include/linux/kernel.h:875:24: note: in expansion of macro '__safe_cmp'
875 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
include/linux/kernel.h:891:19: note: in expansion of macro '__careful_cmp'
891 | #define max(x, y) __careful_cmp(x, y, >)
| ^~~~~~~~~~~~~
arch/riscv/kernel/text.c:12:3: note: in expansion of macro 'max'
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~
arch/riscv/kernel/text.c:12:7: note: in expansion of macro 'PFN_ALIGN'
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~~~~~~~
arch/riscv/kernel/text.c:15:39: note: in expansion of macro 'VMALLOC_MODULE_START'
15 | return __vmalloc_node_range(size, 1, VMALLOC_MODULE_START,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:875:2: error: first argument to '__builtin_choose_expr' not a constant
875 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:891:19: note: in expansion of macro '__careful_cmp'
891 | #define max(x, y) __careful_cmp(x, y, >)
| ^~~~~~~~~~~~~
arch/riscv/kernel/text.c:12:3: note: in expansion of macro 'max'
12 | max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
| ^~~
arch/riscv/kernel/text.c:15:39: note: in expansion of macro 'VMALLOC_MODULE_START'
15 | return __vmalloc_node_range(size, 1, VMALLOC_MODULE_START,
| ^~~~~~~~~~~~~~~~~~~~
>> arch/riscv/kernel/text.c:19:1: warning: control reaches end of non-void function [-Wreturn-type]
19 | }
| ^
vim +12 arch/riscv/kernel/text.c
> 6 #include <linux/mm.h>
7 #include <linux/moduleloader.h>
8 #include <linux/vmalloc.h>
9
10 #if defined(CONFIG_MMU) && defined(CONFIG_64BIT)
11 #define VMALLOC_MODULE_START \
> 12 max(PFN_ALIGN((unsigned long)&_end - SZ_2G), VMALLOC_START)
13 void *text_alloc(unsigned long size)
14 {
15 return __vmalloc_node_range(size, 1, VMALLOC_MODULE_START,
16 VMALLOC_END, GFP_KERNEL,
17 PAGE_KERNEL_EXEC, 0, NUMA_NO_NODE,
18 __builtin_return_address(0));
> 19 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (65175 bytes)
Powered by blists - more mailing lists