linux-kernel - Re: [PATCH -next] bootconfig: Make symbol 'xbc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 23:58:54 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Vlastimil Babka <vbabka@...e.cz>,
        "glider@...gle.com" <glider@...gle.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static

On Tue, 14 Jul 2020 22:25:04 +0800
Wei Yongjun <weiyongjun1@...wei.com> wrote:

> Fix sparse build warning:
> 
> init/main.c:305:6: warning:
>  symbol 'xbc_namebuf' was not declared. Should it be static?

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you,

> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 9127b240fd26..6a24981c727f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
>  
>  #ifdef CONFIG_BOOT_CONFIG
>  
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>  
>  #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>  
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>