linux-kernel - Re: [PATCH 1/2] serial: tegra: fix CREAD handling for PIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200714155200.GB251696@ulmo>
Date:   Tue, 14 Jul 2020 17:52:00 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Laxman Dewangan <ldewangan@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-serial@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>,
        Shardar Shariff Md <smohammed@...dia.com>,
        Krishna Yarlagadda <kyarlagadda@...dia.com>
Subject: Re: [PATCH 1/2] serial: tegra: fix CREAD handling for PIO

On Fri, Jul 10, 2020 at 03:59:46PM +0200, Johan Hovold wrote:
> Commit 33ae787b74fc ("serial: tegra: add support to ignore read") added
> support for dropping input in case CREAD isn't set, but for PIO the
> ignore_status_mask wasn't checked until after the character had been
> put in the receive buffer.
> 
> Note that the NULL tty-port test is bogus and will be removed by a
> follow-on patch.
> 
> Fixes: 33ae787b74fc ("serial: tegra: add support to ignore read")
> Cc: stable <stable@...r.kernel.org>     # 5.4
> Cc: Shardar Shariff Md <smohammed@...dia.com>
> Cc: Krishna Yarlagadda <kyarlagadda@...dia.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/tty/serial/serial-tegra.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Looks good to me:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)