[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200714161948.GA2092551@kroah.com>
Date: Tue, 14 Jul 2020 18:19:48 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] hpilo: Replace one-element array with
flexible-array member
On Tue, Jul 14, 2020 at 10:44:49AM -0500, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> For this particular case, it is important to notice that the cachelines
> change from 7 to 6 after the flexible-array conversion:
That's really funny to see. Nice work, I'll go queue this up. I doubt
anyone will notice as this is a very old driver :)
thanks,
greg k-h
Powered by blists - more mailing lists