linux-kernel - Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 00:22:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     B K Karthik <bkkarthik@...u.pes.edu>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system:
 host: csi_rx.c: fixed a sparse warning by making undeclared symbols static

Hi K,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/B-K-Karthik/drivers-staging-media-atomisp-pci-css_2401_system-host-csi_rx-c-fixed-a-sparse-warning-by-making-undeclared-symbols-static/20200714-212512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git caaba08f8c0dbe5c8fcb497faa7e3b394c21ff39
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:18:18: warning: unused variable 'N_SHORT_PACKET_LUT_ENTRIES' [-Wunused-const-variable]
   static const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
                    ^
>> drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:24:18: warning: unused variable 'N_LONG_PACKET_LUT_ENTRIES' [-Wunused-const-variable]
   static const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
                    ^
>> drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:30:18: warning: unused variable 'N_CSI_RX_FE_CTRL_DLANES' [-Wunused-const-variable]
   static const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = {
                    ^
>> drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c:37:18: warning: unused variable 'N_CSI_RX_BE_SID_WIDTH' [-Wunused-const-variable]
   static const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = {
                    ^
   4 warnings generated.

vim +/N_SHORT_PACKET_LUT_ENTRIES +18 drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c

    17	
  > 18	static const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
    19		4,	/* 4 entries at CSI_RX_BACKEND0_ID*/
    20		4,	/* 4 entries at CSI_RX_BACKEND1_ID*/
    21		4	/* 4 entries at CSI_RX_BACKEND2_ID*/
    22	};
    23	
  > 24	static const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = {
    25		8,	/* 8 entries at CSI_RX_BACKEND0_ID*/
    26		4,	/* 4 entries at CSI_RX_BACKEND1_ID*/
    27		4	/* 4 entries at CSI_RX_BACKEND2_ID*/
    28	};
    29	
  > 30	static const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = {
    31		N_CSI_RX_DLANE_ID,	/* 4 dlanes for CSI_RX_FR0NTEND0_ID */
    32		N_CSI_RX_DLANE_ID,	/* 4 dlanes for CSI_RX_FR0NTEND1_ID */
    33		N_CSI_RX_DLANE_ID	/* 4 dlanes for CSI_RX_FR0NTEND2_ID */
    34	};
    35	
    36	/* sid_width for CSI_RX_BACKEND<N>_ID */
  > 37	static const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = {

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (75331 bytes)