linux-kernel - Re: [PATCH 18/25] pinctrl: pinctrl-bm1880: Rename ill documented struct attribute entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200714171742.GA7260@Mani-XPS-13-9360>
Date:   Tue, 14 Jul 2020 22:47:42 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH 18/25] pinctrl: pinctrl-bm1880: Rename ill documented
 struct attribute entries

On Mon, Jul 13, 2020 at 03:49:23PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pctrldev' not described in 'bm1880_pinctrl'
>  drivers/pinctrl/pinctrl-bm1880.c:40: warning: Function parameter or member 'pinconf' not described in 'bm1880_pinctrl'
> 
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks,
Mani

> ---
>  drivers/pinctrl/pinctrl-bm1880.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index d1a7d98367870..a8e267237435f 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -22,12 +22,12 @@
>  /**
>   * struct bm1880_pinctrl - driver data
>   * @base:	Pinctrl base address
> - * @pctrl:	Pinctrl device
> + * @pctrldev:	Pinctrl device
>   * @groups:	Pingroups
>   * @ngroups:	Number of @groups
>   * @funcs:	Pinmux functions
>   * @nfuncs:	Number of @funcs
> - * @pconf:	Pinconf data
> + * @pinconf:	Pinconf data
>   */
>  struct bm1880_pinctrl {
>  	void __iomem *base;
> -- 
> 2.25.1
>