linux-kernel - Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8131724.iLJVplcRQ0@phil>
Date:   Tue, 14 Jul 2020 20:30:18 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     linus.walleij@...aro.org, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 07/25] pinctrl: samsung: pinctrl-s3c24xx: Fix formatting issues

Am Montag, 13. Juli 2020, 16:49:12 CEST schrieb Lee Jones:
> Kerneldoc struct titles must be followed by whitespace.  Also attributes
> need to be in the format '@.*: ' else the checker gets confused.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c:100: warning: cannot understand function prototype: 'struct s3c24xx_eint_domain_data '
> 
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Tomasz Figa <tomasz.figa@...il.com>
> Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: linux-samsung-soc@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 9bd0a3de101dd..5e24838a582f5 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -80,7 +80,7 @@ static const struct samsung_pin_bank_type bank_type_2bit = {
>  	}
>  
>  /**
> - * struct s3c24xx_eint_data: EINT common data
> + * struct s3c24xx_eint_data - EINT common data
>   * @drvdata: pin controller driver data
>   * @domains: IRQ domains of particular EINT interrupts
>   * @parents: mapped parent irqs in the main interrupt controller
> @@ -92,10 +92,10 @@ struct s3c24xx_eint_data {
>  };
>  
>  /**
> - * struct s3c24xx_eint_domain_data: per irq-domain data
> + * struct s3c24xx_eint_domain_data - per irq-domain data
>   * @bank: pin bank related to the domain
>   * @eint_data: common data
> - * eint0_3_parent_only: live eints 0-3 only in the main intc
> + * @eint0_3_parent_only: live eints 0-3 only in the main intc
>   */
>  struct s3c24xx_eint_domain_data {
>  	struct samsung_pin_bank *bank;
>