linux-kernel - Re: [PATCH] ocfs2: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1f15c7c-d1c5-f87a-4d51-ed55a258dae4@linux.alibaba.com>
Date:   Tue, 14 Jul 2020 13:14:11 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>, mark@...heh.com,
        jlbec@...lplan.org, corbet@....net, ocfs2-devel@....oracle.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: Replace HTTP links with HTTPS ones



On 2020/7/14 01:44, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>             If both the HTTP and HTTPS versions
>             return 200 OK and serve the same content:
>               Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>

Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  Continuing my work started at 93431e0607e5.
>  See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
>  (Actually letting a shell for loop submit all this stuff for me.)
> 
>  If there are any URLs to be removed completely or at least not just HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also: https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See: https://lkml.org/lkml/2020/6/26/837
> 
>  If you apply the patch, please let me know.
> 
>  Sorry again to all maintainers who complained about subject lines.
>  Now I realized that you want an actually perfect prefixes,
>  not just subsystem ones.
>  I tried my best...
>  And yes, *I could* (at least half-)automate it.
>  Impossible is nothing! :)
> 
> 
>  Documentation/filesystems/dlmfs.rst | 2 +-
>  Documentation/filesystems/ocfs2.rst | 2 +-
>  fs/ocfs2/Kconfig                    | 6 +++---
>  fs/ocfs2/blockcheck.c               | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/filesystems/dlmfs.rst b/Documentation/filesystems/dlmfs.rst
> index 68daaa7facf9..28dd41a63be2 100644
> --- a/Documentation/filesystems/dlmfs.rst
> +++ b/Documentation/filesystems/dlmfs.rst
> @@ -12,7 +12,7 @@ dlmfs is built with OCFS2 as it requires most of its infrastructure.
>  
>  :Project web page:    http://ocfs2.wiki.kernel.org
>  :Tools web page:      https://github.com/markfasheh/ocfs2-tools
> -:OCFS2 mailing lists: http://oss.oracle.com/projects/ocfs2/mailman/
> +:OCFS2 mailing lists: https://oss.oracle.com/projects/ocfs2/mailman/
>  
>  All code copyright 2005 Oracle except when otherwise noted.
>  
> diff --git a/Documentation/filesystems/ocfs2.rst b/Documentation/filesystems/ocfs2.rst
> index 412386bc6506..42ca9a3d4c6e 100644
> --- a/Documentation/filesystems/ocfs2.rst
> +++ b/Documentation/filesystems/ocfs2.rst
> @@ -14,7 +14,7 @@ get "mount.ocfs2" and "ocfs2_hb_ctl".
>  
>  Project web page:    http://ocfs2.wiki.kernel.org
>  Tools git tree:      https://github.com/markfasheh/ocfs2-tools
> -OCFS2 mailing lists: http://oss.oracle.com/projects/ocfs2/mailman/
> +OCFS2 mailing lists: https://oss.oracle.com/projects/ocfs2/mailman/
>  
>  All code copyright 2005 Oracle except when otherwise noted.
>  
> diff --git a/fs/ocfs2/Kconfig b/fs/ocfs2/Kconfig
> index aca16624b370..5d11380d8724 100644
> --- a/fs/ocfs2/Kconfig
> +++ b/fs/ocfs2/Kconfig
> @@ -16,9 +16,9 @@ config OCFS2_FS
>  	  You'll want to install the ocfs2-tools package in order to at least
>  	  get "mount.ocfs2".
>  
> -	  Project web page:    http://oss.oracle.com/projects/ocfs2
> -	  Tools web page:      http://oss.oracle.com/projects/ocfs2-tools
> -	  OCFS2 mailing lists: http://oss.oracle.com/projects/ocfs2/mailman/
> +	  Project web page:    https://oss.oracle.com/projects/ocfs2
> +	  Tools web page:      https://oss.oracle.com/projects/ocfs2-tools
> +	  OCFS2 mailing lists: https://oss.oracle.com/projects/ocfs2/mailman/
>  
>  	  For more information on OCFS2, see the file
>  	  <file:Documentation/filesystems/ocfs2.rst>.
> diff --git a/fs/ocfs2/blockcheck.c b/fs/ocfs2/blockcheck.c
> index eaf042feaf5e..6e07ddb0e3c0 100644
> --- a/fs/ocfs2/blockcheck.c
> +++ b/fs/ocfs2/blockcheck.c
> @@ -124,7 +124,7 @@ u32 ocfs2_hamming_encode(u32 parity, void *data, unsigned int d, unsigned int nr
>  		 * parity bits that are part of the bit number
>  		 * representation.  Huh?
>  		 *
> -		 * <wikipedia href="http://en.wikipedia.org/wiki/Hamming_code">
> +		 * <wikipedia href="https://en.wikipedia.org/wiki/Hamming_code">
>  		 * In other words, the parity bit at position 2^k
>  		 * checks bits in positions having bit k set in
>  		 * their binary representation.  Conversely, for
>