linux-kernel - Re: [PATCH v3] x86/entry: Fix vectors to IDTENTRY_SYSVEC for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdnahj-izQo7BfC9cWDH9BXbnSBMdz=TjB9Rtn8ftvz7Og@mail.gmail.com>
Date:   Tue, 14 Jul 2020 13:15:08 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Wei Liu <wei.liu@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Jian Cai <caij2003@...il.com>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH v3] x86/entry: Fix vectors to IDTENTRY_SYSVEC for CONFIG_HYPERV

On Tue, Jul 14, 2020 at 12:48 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> When assembling with Clang via `make LLVM_IAS=1` and CONFIG_HYPERV enabled,
> we observe the following error:
>
> <instantiation>:9:6: error: expected absolute expression
>  .if HYPERVISOR_REENLIGHTENMENT_VECTOR == 3
>      ^
> <instantiation>:1:1: note: while in macro instantiation
> idtentry HYPERVISOR_REENLIGHTENMENT_VECTOR asm_sysvec_hyperv_reenlightenment sysvec_hyperv_reenlightenment has_error_code=0
> ^
> ./arch/x86/include/asm/idtentry.h:627:1: note: while in macro instantiation
> idtentry_sysvec HYPERVISOR_REENLIGHTENMENT_VECTOR sysvec_hyperv_reenlightenment;
> ^
> <instantiation>:9:6: error: expected absolute expression
>  .if HYPERVISOR_STIMER0_VECTOR == 3
>      ^
> <instantiation>:1:1: note: while in macro instantiation
> idtentry HYPERVISOR_STIMER0_VECTOR asm_sysvec_hyperv_stimer0 sysvec_hyperv_stimer0 has_error_code=0
> ^
> ./arch/x86/include/asm/idtentry.h:628:1: note: while in macro instantiation
> idtentry_sysvec HYPERVISOR_STIMER0_VECTOR sysvec_hyperv_stimer0;
>
> This is caused by typos in arch/x86/include/asm/idtentry.h:
>
> HYPERVISOR_REENLIGHTENMENT_VECTOR -> HYPERV_REENLIGHTENMENT_VECTOR
> HYPERVISOR_STIMER0_VECTOR         -> HYPERV_STIMER0_VECTOR
>
> For more details see ClangBuiltLinux issue #1088.
>
> Cc: Jian Cai <caij2003@...il.com>
> Fixes: a16be368dd3f ("x86/entry: Convert various hypervisor vectors to IDTENTRY_SYSVEC")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1088
> Reviewed-by: Nathan Chancellor <natechancellor@...il.com>
> Reviewed-by: Wei Liu <wei.liu@...nel.org>
> Suggested-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@...il.com>

Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

LGTM, thanks Sedat.

> ---
> Personal note:
> I also needed Jian's patch to completely build with LLVM_IAS=1" but
> I don't think that should be in the message that gets committed per
> se. Without Jian's patch we did NOT catch this one!
> Link: https://github.com/ClangBuiltLinux/linux/issues/1043
> Link: https://lore.kernel.org/patchwork/patch/1272115/
>
> Changes v2->v3:
> - Fold in comments suggested by Nick
> - Add Nick's Suggested-by
> - Drop unneeded tags and order the rest alphabetically
> - Move comments and links to Jian's patch to a personal note
>
> Changes v1->v2:
> - Add Wei Liu's Reviewed-by
> - Add note to clarify my patch is independent from Jian's patch
> - Add link to latest version of Jian's patch
>
>  arch/x86/include/asm/idtentry.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
> index eeac6dc2adaa..d79541bfc36f 100644
> --- a/arch/x86/include/asm/idtentry.h
> +++ b/arch/x86/include/asm/idtentry.h
> @@ -626,8 +626,8 @@ DECLARE_IDTENTRY_SYSVEC(POSTED_INTR_NESTED_VECTOR,  sysvec_kvm_posted_intr_nested
>
>  #if IS_ENABLED(CONFIG_HYPERV)
>  DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_CALLBACK_VECTOR,    sysvec_hyperv_callback);
> -DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_REENLIGHTENMENT_VECTOR,     sysvec_hyperv_reenlightenment);
> -DECLARE_IDTENTRY_SYSVEC(HYPERVISOR_STIMER0_VECTOR,     sysvec_hyperv_stimer0);
> +DECLARE_IDTENTRY_SYSVEC(HYPERV_REENLIGHTENMENT_VECTOR, sysvec_hyperv_reenlightenment);
> +DECLARE_IDTENTRY_SYSVEC(HYPERV_STIMER0_VECTOR, sysvec_hyperv_stimer0);
>  #endif
>
>  #if IS_ENABLED(CONFIG_ACRN_GUEST)
> --
> 2.28.0.rc0
>


-- 
Thanks,
~Nick Desaulniers