linux-kernel - Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 06:22:29 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Bixuan Cui <cuibixuan@...wei.com>
Cc:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
        <john.wanghui@...wei.com>, Roman Gushchin <guro@...com>
Subject: Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning

Hi Bixuan,

Thanks for this.

On Tue, 14 Jul 2020 21:46:18 +0800 Bixuan Cui <cuibixuan@...wei.com> wrote:
>
> Gcc report the following warning without CONFIG_MEMCG_KMEM:
> 
> mm/percpu-internal.h:145:29: warning: 'pcpu_chunk_type' defined
> but not used [-Wunused-function]
>  static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk)
>                              ^~~~~~~~~~~~~~~
> 
> Add 'inline' to pcpu_chunk_type(),pcpu_is_memcg_chunk() and
> pcpu_chunk_list() to clear warning.
> 
> Fixes: 26c99879ef01 ("mm: memcg/percpu: account percpu memory to memory cgroups")
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

You really should not add SUB lines for others - in  this case a
Suggested-by is more appropriate.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped