linux-kernel - Re: [PATCH 08/18] perf metric: Rename __metricgroup__add_metric to __add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXjg1MSzzHHiSeco-dTZpwufJkHwTY6LHZ-xz9LEv94eA@mail.gmail.com>
Date:   Tue, 14 Jul 2020 14:11:32 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Michael Petlan <mpetlan@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        John Garry <john.garry@...wei.com>,
        "Paul A. Clarke" <pc@...ibm.com>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 08/18] perf metric: Rename __metricgroup__add_metric to __add_metric

On Sun, Jul 12, 2020 at 6:27 AM Jiri Olsa <jolsa@...nel.org> wrote:
>
> Renaming __metricgroup__add_metric to __add_metric
> to fit in the current function names.
>
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>

Acked-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/util/metricgroup.c | 17 ++++++-----------
>  1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index 9a168f3df7a4..f0b0a053bfd2 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -571,10 +571,10 @@ int __weak arch_get_runtimeparam(void)
>         return 1;
>  }
>
> -static int __metricgroup__add_metric(struct list_head *group_list,
> -                                    struct pmu_event *pe,
> -                                    bool metric_no_group,
> -                                    int runtime)
> +static int __add_metric(struct list_head *group_list,
> +                       struct pmu_event *pe,
> +                       bool metric_no_group,
> +                       int runtime)
>  {
>         struct egroup *eg;
>
> @@ -643,10 +643,7 @@ static int add_metric(struct list_head *group_list,
>         pr_debug("metric expr %s for %s\n", pe->metric_expr, pe->metric_name);
>
>         if (!strstr(pe->metric_expr, "?")) {
> -               ret = __metricgroup__add_metric(group_list,
> -                                               pe,
> -                                               metric_no_group,
> -                                               1);
> +               ret = __add_metric(group_list, pe, metric_no_group, 1);
>         } else {
>                 int j, count;
>
> @@ -658,9 +655,7 @@ static int add_metric(struct list_head *group_list,
>                  */
>
>                 for (j = 0; j < count && !ret; j++) {
> -                       ret = __metricgroup__add_metric(
> -                               group_list, pe,
> -                               metric_no_group, j);
> +                       ret = __add_metric(group_list, pe, metric_no_group, j);
>                 }
>         }
>
> --
> 2.25.4
>