linux-kernel - Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566faf7eeec336d0ecfa9bd16790d6e3042b9267.camel@intel.com>
Date:   Tue, 14 Jul 2020 23:25:35 +0000
From:   "Westergreen, Dalon" <dalon.westergreen@...el.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "Tan, Ley Foon" <ley.foon.tan@...el.com>,
        "See, Chin Liang" <chin.liang.see@...el.com>,
        "Nguyen, Dinh" <dinh.nguyen@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Ooi, Joyce" <joyce.ooi@...el.com>,
        "thor.thayer@...ux.intel.com" <thor.thayer@...ux.intel.com>
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher



On Tue, 2020-07-14 at 13:23 -0700, David Miller wrote:
> From: "Westergreen, Dalon" <dalon.westergreen@...el.com>
> Date: Tue, 14 Jul 2020 18:51:15 +0000
> 
> > I don't think this is necessary, i think just having a module parameter
> > meets our needs.  I don't see a need for the value to change on a per
> > interface basis.  This was primarily used during testing / bringup.
> 
> Please no module parameters...

I think we are fine just hard coding the value.  that seems to be the best path
forward.

--dalon