linux-kernel - [PATCH -next] dmaengine: idxd: fix PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dee3f46-70d9-ea75-10cb-5527ab297d1d@infradead.org>
Date:   Mon, 13 Jul 2020 23:35:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Cc:     Dave Jiang <dave.jiang@...el.com>, Vinod Koul <vkoul@...nel.org>
Subject: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors when CONFIG_PCI_MSI is not enabled by making the
driver depend on PCI_MSI:

ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Dave Jiang <dave.jiang@...el.com>
Cc: dmaengine@...r.kernel.org
Cc: Vinod Koul <vkoul@...nel.org>
---
 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
+++ mmotm-2020-0713-1949/drivers/dma/Kconfig
@@ -285,6 +285,7 @@ config INTEL_IDMA64
 config INTEL_IDXD
 	tristate "Intel Data Accelerators support"
 	depends on PCI && X86_64
+	depends on PCI_MSI
 	depends on SBITMAP
 	select DMA_ENGINE
 	help