linux-kernel - Re: [PATCH v2 19/29] scsi: aic7xxx: aic7xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94cecb13-2df9-9ee8-0341-9d0165f831d4@suse.de>
Date:   Tue, 14 Jul 2020 09:07:09 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Lee Jones <lee.jones@...aro.org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        Hannes Reinecke <hare@...e.com>,
        "Daniel M. Eischen" <deischen@...rks.InterWorks.org>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH v2 19/29] scsi: aic7xxx: aic7xxx_osm: Remove unused
 variable 'ahc'

On 7/13/20 9:46 AM, Lee Jones wrote:
> Looks as though 'ahc' hasn't been used since 2005.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/scsi/aic7xxx/aic7xxx_osm.c: In function ‘ahc_linux_slave_configure’:
>   drivers/scsi/aic7xxx/aic7xxx_osm.c:674:20: warning: variable ‘ahc’ set but not used [-Wunused-but-set-variable]
>   674 | struct ahc_softc *ahc;
>   | ^~~
> 
> Cc: Hannes Reinecke <hare@...e.com>
> Cc: "Daniel M. Eischen" <deischen@...rks.InterWorks.org>
> Cc: Doug Ledford <dledford@...hat.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/scsi/aic7xxx/aic7xxx_osm.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index 32bfe20d79cc1..cc4c7b1781466 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> @@ -666,10 +666,6 @@ ahc_linux_slave_alloc(struct scsi_device *sdev)
>   static int
>   ahc_linux_slave_configure(struct scsi_device *sdev)
>   {
> -	struct	ahc_softc *ahc;
> -
> -	ahc = *((struct ahc_softc **)sdev->host->hostdata);
> -
>   	if (bootverbose)
>   		sdev_printk(KERN_INFO, sdev, "Slave Configure\n");
>   
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@...e.de                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer