linux-kernel - Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83b230cef109e1a413ab1036c21ad763a1d127eb.camel@toradex.com>
Date:   Tue, 14 Jul 2020 08:20:34 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "a.fatoum@...gutronix.de" <a.fatoum@...gutronix.de>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch
 capability

On Tue, 2020-07-14 at 09:55 +0200, Ahmad Fatoum wrote:
> Hello Philippe,
> 
> On 7/13/20 1:53 PM, Philippe Schenker wrote:
> > On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote:
> > > Hello Philippe,
> > > 
> > > > +	extcon_usbc_det: usbc_det {
> > > > +		compatible = "linux,extcon-usb-gpio";
> > > 
> > > According to 4602f3bff266 ("usb: common: add USB GPIO based
> > > connection
> > > detection driver"):
> > > "the old way using extcon to support USB Dual-Role switch is now
> > > deprecated
> > >  when use Type-B connector."
> > > 
> > > Have you considered using a compatible = "gpio-usb-b-connector"
> > > child
> > > node instead?
> > > 
> > > Cheers,
> > > Ahmad
> > 
> > Thanks for the Hint Ahmad,
> > 
> > I already tried and just now tried again but it doesn't work on our
> > hardware. Are you sure this works with chipidea driver?
> 
> I haven't, just wanted to point its existence out in case you didn't
> know.
> Seems we need to call of_platform_populate somewhere in the driver.
> Unsure what other changes are necessary.

Yep, thanks for that! It seems like that need to be really called as I
can't get a probe of the new usb connector driver. I quickly grepped
through code and saw that tegra USB driver is calling
of_platform_populate and they also use that gpio-usb-b-connector.

> 
> > Should this new usb-connector stuff work in general with every old
> > driver?
> 
> If the driver support isn't there yet, I think use of extcon is fine
> as is.
> 
> Thanks
> Ahmad

@Shawn: Could you pull patches #2 and #3 back in?

Thanks guys!

Philippe
> 
> > Philippe
> 
>