linux-kernel - Re: [PATCH] net: xilinx: fix potential NULL dereference in temac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <d0873e01-4e07-ca59-ff6b-64ac6ee6aba4@web.de>
Date:   Tue, 14 Jul 2020 11:42:32 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Xu Wang <vulab@...as.ac.cn>,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Esben Haabendal <esben@...nix.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Wei Yongjun <weiyongjun1@...wei.com>
Subject: Re: [PATCH] net: xilinx: fix potential NULL dereference in
 temac_probe()

> If you use devm_ioremap_resource() you can remove the !res check
> entirely which would be equally acceptable as a fix.

Would you like to use the wrapper function “devm_platform_get_and_ioremap_resource” then?
https://elixir.bootlin.com/linux/v5.8-rc4/source/drivers/base/platform.c#L66
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c?id=0dc589da873b58b70f4caf4b070fb0cf70fdd1dc#n66

Regards,
Markus