linux-kernel - Re: [PATCH v2 2/3] dt-bindings: MIPS: Add Ingenic X1830 based boards.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200714023212.GA1162143@bogus>
Date:   Mon, 13 Jul 2020 20:32:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, paul.burton@...s.com,
        paul@...pouillou.net, tsbogend@...ha.franken.de,
        ak@...ux.intel.com, ebiederm@...ssion.com,
        dongsheng.qiu@...enic.com, aric.pzqi@...enic.com,
        rick.tyliu@...enic.com, yanfei.li@...enic.com,
        sernia.zhou@...mail.com, zhenwenjin@...il.com
Subject: Re: [PATCH v2 2/3] dt-bindings: MIPS: Add Ingenic X1830 based boards.

On Fri, Jun 26, 2020 at 01:37:15AM +0800, 周琰杰 (Zhou Yanjie) wrote:
> Add bindings for Ingenic X1830 based board, prepare for later dts.
> 
> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@...mail.com>
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> ---
> 
> Notes:
>     v1->v2:
>     No change.
> 
>  Documentation/devicetree/bindings/mips/ingenic/devices.yaml | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mips/ingenic/devices.yaml b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
> index d1175030781a..feb695be9f66 100644
> --- a/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
> @@ -8,7 +8,8 @@ title: Ingenic XBurst based Platforms Device Tree Bindings
>  
>  maintainers:
>    - 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> -description: |
> +
> +description:
>    Devices with a Ingenic XBurst CPU shall have the following properties.
>  
>  properties:
> @@ -32,8 +33,13 @@ properties:
>            - const: img,ci20
>            - const: ingenic,jz4780
>  
> -      - description: YSH & ATIL General Board CU Neo
> +      - description: YSH & ATIL General Board, CU1000 Module with Neo Backplane
>          items:
>            - const: yna,cu1000-neo
> -          - const: ingenic,x1000
> +          - const: ingenic,x1000e

What's this change? You can't just change bindings.

> +
> +      - description: YSH & ATIL General Board, CU1830 Module with Neo Backplane
> +        items:
> +          - const: yna,cu1830-neo
> +          - const: ingenic,x1830
>  ...
> -- 
> 2.11.0
>