[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5614bc2e.1259.1734d41040f.Coremail.zhangqing@loongson.cn>
Date: Tue, 14 Jul 2020 20:16:13 +0800 (GMT+08:00)
From: "Qing Zhang" <zhangqing@...ngson.cn>
To: "Mark Brown" <broonie@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
"Xuefeng Li" <lixuefeng@...ngson.cn>,
"Tiezhu Yang" <yangtiezhu@...ngson.cn>
Subject: Re: Re: [PATCH] spi: Use clk_prepare_enable and
clk_disable_unprepare
> -----Original Messages-----
> From: "Mark Brown" <broonie@...nel.org>
> Sent Time: 2020-07-14 17:44:06 (Tuesday)
> To: "Qing Zhang" <zhangqing@...ngson.cn>
> Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org, "Xuefeng Li" <lixuefeng@...ngson.cn>, "Tiezhu Yang" <yangtiezhu@...ngson.cn>
> Subject: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare
>
> On Tue, Jul 14, 2020 at 05:09:14PM +0800, Qing Zhang wrote:
> > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
> > calls as required by common clock framework.
> >
> > Signed-off-by: Qing Zhang <zhangqing@...ngson.cn>
> > ---
> > drivers/spi/spi-coldfire-qspi.c | 4 ++--
>
> Are you sure that ColdFire uses the common clock framework?
>
> > drivers/spi/spi-omap-uwire.c | 4 ++--
>
> It makes life easier if you send per-driver patches, that makes it
> easier for driver maintainers to review things and means that issues
> with a change in one driver won't hold up another.
Hi Mark,
Thank you for your suggestion.
I will split this patch into two patches and then send v2.
</zhangqing@...ngson.cn></yangtiezhu@...ngson.cn></lixuefeng@...ngson.cn></zhangqing@...ngson.cn></broonie@...nel.org>
Powered by blists - more mailing lists