linux-kernel - Re: [PATCH] mm/percpu: mark pcpu_chunk_type() as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200714225311.7aeffffd@canb.auug.org.au>
Date:   Tue, 14 Jul 2020 22:53:11 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Bixuan Cui <cuibixuan@...wei.com>
Cc:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>,
        <john.wanghui@...wei.com>, Roman Gushchin <guro@...com>
Subject: Re: [PATCH] mm/percpu: mark pcpu_chunk_type() as __maybe_unused

Hi Bixuan,

On Tue, 14 Jul 2020 13:41:01 +0000 Bixuan Cui <cuibixuan@...wei.com> wrote:
>
> Gcc report the following warning without CONFIG_MEMCG_KMEM:
> 
> mm/percpu-internal.h:145:29: warning: ‘pcpu_chunk_type’ defined
> but not used [-Wunused-function]
>  static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk)
>                              ^~~~~~~~~~~~~~~
> 
> Mark pcpu_chunk_type() as __maybe_unused to make it clear.

Given that it is in a header file, it should probably just be "static
inline" (which will also suppress the warning).  As should
pcpu_is_memcg_chunk() and pcpu_chunk_list().  Also, without them being
inline, there will be a new copy for each file that
mm/percpu-internal.h is included in.

And that should be considered a fix for "mm: memcg/percpu: account
percpu memory to memory cgroups".

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped