linux-kernel - Re: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 14:40:32 +0100
From:   Måns Rullgård <mans@...sr.com>
To:     Chen-Yu Tsai <wens@...nel.org>
Cc:     Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Chen-Yu Tsai <wens@...e.org>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: sun4i: hdmi: Fix inverted HPD result

Chen-Yu Tsai <wens@...nel.org> writes:

> From: Chen-Yu Tsai <wens@...e.org>
>
> When the extra HPD polling in sun4i_hdmi was removed, the result of
> HPD was accidentally inverted.
>
> Fix this by inverting the check.
>
> Fixes: bda8eaa6dee7 ("drm: sun4i: hdmi: Remove extra HPD polling")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Tested-by: Mans Rullgard <mans@...sr.com>

> ---
>
> Sorry for the screw-up.
>
> ---
>  drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> index 557cbe5ab35f..2f2c9f0a1071 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c
> @@ -260,7 +260,7 @@ sun4i_hdmi_connector_detect(struct drm_connector *connector, bool force)
>  	unsigned long reg;
>
>  	reg = readl(hdmi->base + SUN4I_HDMI_HPD_REG);
> -	if (reg & SUN4I_HDMI_HPD_HIGH) {
> +	if (!(reg & SUN4I_HDMI_HPD_HIGH)) {
>  		cec_phys_addr_invalidate(hdmi->cec_adap);
>  		return connector_status_disconnected;
>  	}
> -- 
> 2.27.0
>

-- 
Måns Rullgård