linux-kernel - RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR11MB12537DA07C73574B82A239BDF2610@CY4PR11MB1253.namprd11.prod.outlook.com>
Date:   Tue, 14 Jul 2020 14:35:16 +0000
From:   "Ooi, Joyce" <joyce.ooi@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Thor Thayer <thor.thayer@...ux.intel.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Dalon Westergreen" <dalon.westergreen@...ux.intel.com>,
        "Tan, Ley Foon" <ley.foon.tan@...el.com>,
        "See, Chin Liang" <chin.liang.see@...el.com>,
        "Nguyen, Dinh" <dinh.nguyen@...el.com>,
        "Westergreen, Dalon" <dalon.westergreen@...el.com>
Subject: RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, July 9, 2020 5:49 AM
> To: Ooi, Joyce <joyce.ooi@...el.com>
> Cc: Thor Thayer <thor.thayer@...ux.intel.com>; David S . Miller
> <davem@...emloft.net>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Dalon Westergreen
> <dalon.westergreen@...ux.intel.com>; Tan, Ley Foon
> <ley.foon.tan@...el.com>; See, Chin Liang <chin.liang.see@...el.com>;
> Nguyen, Dinh <dinh.nguyen@...el.com>; Westergreen, Dalon
> <dalon.westergreen@...el.com>
> Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
> 
> On Wed,  8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote:
> > +		/* get prefetcher rx poll frequency from device tree */
> > +		if (of_property_read_u32(pdev->dev.of_node, "rx-poll-
> freq",
> > +					 &priv->rx_poll_freq)) {
> > +			dev_info(&pdev->dev, "Defaulting RX Poll Frequency
> to 128\n");
> > +			priv->rx_poll_freq = 128;
> > +		}
> > +
> > +		/* get prefetcher rx poll frequency from device tree */
> > +		if (of_property_read_u32(pdev->dev.of_node, "tx-poll-
> freq",
> > +					 &priv->tx_poll_freq)) {
> > +			dev_info(&pdev->dev, "Defaulting TX Poll Frequency
> to 128\n");
> > +			priv->tx_poll_freq = 128;
> > +		}
> 
> I'm no device tree expert but these look like config options rather than HW
> description. They also don't appear to be documented in the next patch.

The poll_freq are part of the msgdma prefetcher IP, whereby it specifies the frequency of descriptor polling operation.
I can add the poll_freq description in the next patch.