linux-kernel - Re: [PATCH] sound/pci/hda: Changes 'blacklist/whitelist' to 'blocklist/allowlist'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGt04nZLViVautnbeFFMbx=_=0eNbW3fz5AAVKi6wCXDHZn2rA@mail.gmail.com>
Date:   Thu, 16 Jul 2020 04:15:43 +0930
From:   Paul Schulz <paul@...sonlakes.org>
To:     Jonathan Corbet <corbet@....net>
Cc:     linux-kernel@...r.kernel.org, Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH] sound/pci/hda: Changes 'blacklist/whitelist' to 'blocklist/allowlist'

Good news is that appears to be the only case of this particular usage
with MODULE_PARM_DESC
Searching for 'blacklist' and MODULE_PARM gives the following:

sound/pci/hda/hda_intel.c:183:MODULE_PARM_DESC(pm_blacklist, "Enable
power-management blacklist");
arch/x86/crypto/camellia_glue.c:1473:MODULE_PARM_DESC(force, "Force
module load, ignore CPU blacklist");
arch/x86/crypto/twofish_glue_3way.c:251:MODULE_PARM_DESC(force, "Force
module load, ignore CPU blacklist");
arch/x86/crypto/des3_ede_glue.c:467:MODULE_PARM_DESC(force, "Force
module load, ignore CPU blacklist");
arch/x86/crypto/blowfish_glue.c:423:MODULE_PARM_DESC(force, "Force
module load, ignore CPU blacklist");

On Thu, 16 Jul 2020 at 03:45, Paul Schulz <paul@...sonlakes.org> wrote:
>
> Yep. +1 for logic
>
> On Thu, 16 Jul 2020 at 03:11, Jonathan Corbet <corbet@....net> wrote:
> >
> > On Thu, 16 Jul 2020 01:52:04 +0930
> > Paul Schulz <paul@...sonlakes.org> wrote:
> >
> > > -static bool pm_blacklist = true;
> > > -module_param(pm_blacklist, bool, 0644);
> > > -MODULE_PARM_DESC(pm_blacklist, "Enable power-management blacklist");
> > > +static bool pm_blocklist = true;
> > > +module_param(pm_blocklist, bool, 0644);
> > > +MODULE_PARM_DESC(pm_blocklist, "Enable power-management blocklist");
> >
> > This will break any user specifying this parameter now, which isn't
> > something you want to do, methinks...
> >
> > jon