linux-kernel - Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header bitrot issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 12:21:38 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     ohad@...ery.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: qcom_sysmon: Solve function header
 bitrot issues

On Wed 15 Jul 05:35 PDT 2020, Lee Jones wrote:

> Looks as though 'name' has now been moved into 'struct sysmod_event'
> which is passed in instead.  However, the parameter descriptions were
> not updated at the same time.  Let's do that now.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/remoteproc/qcom_sysmon.c:78: warning: Function parameter or member 'event' not described in 'sysmon_send_event'
>  drivers/remoteproc/qcom_sysmon.c:78: warning: Excess function parameter 'name' description in 'sysmon_send_event'
>  drivers/remoteproc/qcom_sysmon.c:350: warning: Function parameter or member 'event' not described in 'ssctl_send_event'
>  drivers/remoteproc/qcom_sysmon.c:350: warning: Excess function parameter 'name' description in 'ssctl_send_event'
> 
> Cc: Andy Gross <agross@...nel.org>
> Cc: linux-arm-msm@...r.kernel.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Thanks Lee, both patches applied.

Regards,
Bjorn

> ---
>  drivers/remoteproc/qcom_sysmon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/qcom_sysmon.c b/drivers/remoteproc/qcom_sysmon.c
> index 8d8996d714f07..9eb2f6bccea63 100644
> --- a/drivers/remoteproc/qcom_sysmon.c
> +++ b/drivers/remoteproc/qcom_sysmon.c
> @@ -71,7 +71,7 @@ static LIST_HEAD(sysmon_list);
>  /**
>   * sysmon_send_event() - send notification of other remote's SSR event
>   * @sysmon:	sysmon context
> - * @name:	other remote's name
> + * @event:	sysmon event context
>   */
>  static void sysmon_send_event(struct qcom_sysmon *sysmon,
>  			      const struct sysmon_event *event)
> @@ -343,7 +343,7 @@ static void ssctl_request_shutdown(struct qcom_sysmon *sysmon)
>  /**
>   * ssctl_send_event() - send notification of other remote's SSR event
>   * @sysmon:	sysmon context
> - * @name:	other remote's name
> + * @event:	sysmon event context
>   */
>  static void ssctl_send_event(struct qcom_sysmon *sysmon,
>  			     const struct sysmon_event *event)
> -- 
> 2.25.1
>