linux-kernel - Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a power off on reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1sgdso7sc.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 15 Jul 2020 16:14:23 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Simon Arlott <simon@...iron.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, Bart Van Assche <bvanassche@....org>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Pavel Machek <pavel@....cz>,
        Henrique de Moraes Holschuh <hmh@....eng.br>
Subject: Re: [PATCH 1/2] reboot: add a "power cycle" quirk to prepare for a
 power off on reboot


Christoph,

> Except for the fact that I think that usage of the BIT() macro is
> a horrible pattern, this looks good:
>
> Reviewed-by: Christoph Hellwig <hch@....de>

Looks good to me too.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering