linux-kernel - Re: [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1blkgo6y0.fsf@ca-mkp.ca.oracle.com>
Date:   Wed, 15 Jul 2020 16:53:14 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Simon Arlott <simon@...iron.net>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Park Ju Hyung <qkrwngud825@...il.com>,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] ata: Disable queued TRIM for Samsung 860 SSDs

Hi Simon!

> Despite the unsubstantiated claim from Samsung that "the improved
> queued trim enhances Linux compatibility" this does not appear to be
> true, even on Intel SATA controllers:

I am aware of several people using 860 drives with queued TRIM. And I
haven't heard any complaints outside of the bug you referenced.

Also, I have tested both 860 2.5" Pro and 860 mSATA EVO on a few
different systems in my lab without any problems. See:

    https://lore.kernel.org/stable/yq1h87du82d.fsf@oracle.com/T/

I really wish we had some more data to work with :(

Lacking a proper heuristic I guess we don't have any choice to disable
the feature. But that's sad news for the people who currently don't have
problems since their performance will inevitably suffer.

-- 
Martin K. Petersen	Oracle Linux Engineering