linux-kernel - Re: [PATCH] dt-bindings: mmc: Convert sdhci-sirf to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200715220634.GA897068@bogus>
Date:   Wed, 15 Jul 2020 16:06:34 -0600
From:   Rob Herring <robh@...nel.org>
To:     Kangmin Park <l4stpr0gr4m@...il.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Convert sdhci-sirf to json-schema

On Tue, Jul 07, 2020 at 02:43:36AM +0900, Kangmin Park wrote:
> Convert the sdhci-sirf binding to DT schema format using json-schema.
> 
> At the same time, fix unit address to match the first address specified
> in the reg property of the node.
> 
> Signed-off-by: Kangmin Park <l4stpr0gr4m@...il.com>
> ---
>  .../devicetree/bindings/mmc/sdhci-sirf.txt    | 18 ---------
>  .../devicetree/bindings/mmc/sdhci-sirf.yaml   | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 18 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
>  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt b/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> deleted file mode 100644
> index dd6ed464bcb8..000000000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-sirf.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* SiRFprimII/marco/atlas6 SDHCI Controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci-sirf driver.
> -
> -Required properties:
> -- compatible: sirf,prima2-sdhc
> -
> -Optional properties:
> -- cd-gpios: card detect gpio, with zero flags.
> -
> -Example:
> -
> -	sd0: sdhci@...00000 {
> -		compatible = "sirf,prima2-sdhc";
> -		reg = <0xcd000000 0x100000>;
> -		cd-gpios = <&gpio 6 0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml b/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
> new file mode 100644
> index 000000000000..46269378d9b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-sirf.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sdhci-sirf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sdhci Sirf Device Tree Bindings
> +
> +description: |
> +  This file documents differences between the core properties in
> +  mmc.txt and the properties used by the sdhci-sirf driver.
> +
> +maintainers:
> +  - Ulf Hansson <ulf.hansson@...aro.org>

Normally, this should be someone familar with the h/w, not the MMC 
maintainer.

Needs a reference to mmc-controller.yaml. 

> +
> +properties:
> +  compatible:
> +    enum:
> +      - sirf,prima2-sdhc
> +
> +  reg:
> +    maxItems: 1
> +
> +  cd-gpios:
> +    description:
> +      card detect gpio, with zero flags.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sd0: sdhci@...00000 {
> +          compatible = "sirf,prima2-sdhc";
> +          reg = <0xcd000000 0x100000>;
> +          cd-gpios = <&gpio 6 0>;
> +    };
> -- 
> 2.26.2
>