linux-kernel - Re: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 19:13:08 -0400
From:   Thara Gopinath <thara.gopinath@...aro.org>
To:     Zhang Rui <rui.zhang@...el.com>, daniel.lezcano@...aro.org,
        robh+dt@...nel.org
Cc:     linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing
 for "cold" trip points



On 7/15/20 4:35 AM, Zhang Rui wrote:
> On Fri, 2020-07-10 at 09:51 -0400, Thara Gopinath wrote:
>> For now, thermal governors do not support monitoring of falling
>> temperature. Hence, in case of calls to the governor for trip points
>> marked
>> as cold, return doing nothing.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@...aro.org>
>> ---
>>   drivers/thermal/gov_bang_bang.c       | 8 ++++++++
>>   drivers/thermal/gov_fair_share.c      | 8 ++++++++
>>   drivers/thermal/gov_power_allocator.c | 8 ++++++++
>>   drivers/thermal/gov_step_wise.c       | 8 ++++++++
>>   4 files changed, 32 insertions(+)
> 
> userspace governor does not support cold trip point neither.
> 
> So how about adding the check in handle_non_critical_trips first, and
> remove the check later, after all the governors support cold trip?

Yeah, no governors support cold trip for now. Putting check in 
handle_non_critical_trips is another way to handle this. I can do it and 
come back to this solution when one or more governors start supporting 
cold trip points.


-- 
Warm Regards
Thara