linux-kernel - Re: [PATCH 06/23] md: remove the autoscan partition re-read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878sfkxsia.fsf@notabene.neil.brown.name>
Date:   Thu, 16 Jul 2020 09:34:05 +1000
From:   NeilBrown <neil@...wn.name>
To:     Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Cc:     "H. Peter Anvin" <hpa@...or.com>, Song Liu <song@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-raid@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 06/23] md: remove the autoscan partition re-read

On Tue, Jul 14 2020, Christoph Hellwig wrote:

> devfs is long gone, and autoscan works just fine without this these days.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> Acked-by: Song Liu <song@...nel.org>

Happy to see this go!

Reviewed-by: NeilBrown <neilb@...e.de>

Thanks,
NeilBrown


> ---
>  drivers/md/md-autodetect.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/md/md-autodetect.c b/drivers/md/md-autodetect.c
> index 0eb746211ed53c..6bc9b734eee6ff 100644
> --- a/drivers/md/md-autodetect.c
> +++ b/drivers/md/md-autodetect.c
> @@ -240,16 +240,6 @@ static void __init md_setup_drive(void)
>  			err = ksys_ioctl(fd, RUN_ARRAY, 0);
>  		if (err)
>  			printk(KERN_WARNING "md: starting md%d failed\n", minor);
> -		else {
> -			/* reread the partition table.
> -			 * I (neilb) and not sure why this is needed, but I cannot
> -			 * boot a kernel with devfs compiled in from partitioned md
> -			 * array without it
> -			 */
> -			ksys_close(fd);
> -			fd = ksys_open(name, 0, 0);
> -			ksys_ioctl(fd, BLKRRPART, 0);
> -		}
>  		ksys_close(fd);
>  	}
>  }
> -- 
> 2.27.0

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)