linux-kernel - Re: [PATCH] cifs: Remove the superfluous break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 23:19:05 -0500
From:   Steve French <smfrench@...il.com>
To:     Yi Wang <wang.yi59@....com.cn>
Cc:     Steve French <sfrench@...ba.org>,
        CIFS <linux-cifs@...r.kernel.org>,
        samba-technical <samba-technical@...ts.samba.org>,
        LKML <linux-kernel@...r.kernel.org>, xue.zhihong@....com.cn,
        wang.liang82@....com.cn, Liao Pingfang <liao.pingfang@....com.cn>
Subject: Re: [PATCH] cifs: Remove the superfluous break

merged into cifs-2.6.git for-next

thx

On Tue, Jul 14, 2020 at 6:14 AM Yi Wang <wang.yi59@....com.cn> wrote:
>
> From: Liao Pingfang <liao.pingfang@....com.cn>
>
> Remove the superfuous break, as there is a 'return' before it.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@....com.cn>
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> ---
>  fs/cifs/sess.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
> index 5d05bd2..6708ab0 100644
> --- a/fs/cifs/sess.c
> +++ b/fs/cifs/sess.c
> @@ -1705,7 +1705,6 @@ static int select_sec(struct cifs_ses *ses, struct sess_data *sess_data)
>  #else
>                 cifs_dbg(VFS, "Kerberos negotiated but upcall support disabled!\n");
>                 return -ENOSYS;
> -               break;
>  #endif /* CONFIG_CIFS_UPCALL */
>         case RawNTLMSSP:
>                 sess_data->func = sess_auth_rawntlmssp_negotiate;
> --
> 2.9.5
>


-- 
Thanks,

Steve