linux-kernel - Re: [PATCH -next] dmaengine: idxd: fix PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200715060355.GX34333@vkoul-mobl>
Date:   Wed, 15 Jul 2020 11:33:55 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Dave Jiang <dave.jiang@...el.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors

On 14-07-20, 07:58, Dave Jiang wrote:
> 
> 
> On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@...radead.org>
> > 
> > Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> > driver depend on PCI_MSI:
> > 
> > ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> > device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> > ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> > device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Dave Jiang <dave.jiang@...el.com>
> > Cc: dmaengine@...r.kernel.org
> > Cc: Vinod Koul <vkoul@...nel.org>
> 
> Vinod, I submitted this fix patch last week:
> https://patchwork.kernel.org/patch/11649231/
> 
> But I think maybe Randy's patch may be more preferable? You can apply this
> one and ignore my submission.

Ok, Applied this one, thanks
-- 
~Vinod