linux-kernel - Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200715064746.GU1398296@dell>
Date:   Wed, 15 Jul 2020 07:47:46 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Kim Phillips <kim.phillips@....com>
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID
 structs

On Tue, 14 Jul 2020, Kim Phillips wrote:

> On 7/14/20 4:02 PM, Lee Jones wrote:
> > On Tue, 14 Jul 2020, Kim Phillips wrote:
> >> On 7/14/20 9:50 AM, Lee Jones wrote:
> >>> Can't see them being used anywhere and the compiler doesn't complain
> >>> that they're missing, so ...
> >>>
> >>> Fixes the following W=1 kernel build warning(s):
> >>>
> >>>  drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=]
> >>>  147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = {
> >>>  | ^~~~~~~~~~~~~~~~~~~~~~~~
> >>>
> >>> Cc: Jacob Shin <jacob.shin@....com>
> >>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> >>> ---
> >>
> >> Same comment as for patch 9/13: these are used automatic module loading.
> > 
> > How does that work?
> > 
> > Could you point me to the code which handles that please?
> 
> It's MODULE_DEVICE_TABLE magic.

I'll look into that.  Thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog