linux-kernel - Re: [PATCH -next] scsi: sd_zbc: Remove unused inline functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 07:13:01 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        Damien Le Moal <Damien.LeMoal@....com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] scsi: sd_zbc: Remove unused inline functions

On 15/07/2020 04:56, YueHaibing wrote:
> They are never used, so can remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/scsi/sd.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/sd.h b/drivers/scsi/sd.h
> index 3a74f4b45134..27c0f4e9b1d4 100644
> --- a/drivers/scsi/sd.h
> +++ b/drivers/scsi/sd.h
> @@ -229,17 +229,11 @@ blk_status_t sd_zbc_prepare_zone_append(struct scsi_cmnd *cmd, sector_t *lba,
>  
>  #else /* CONFIG_BLK_DEV_ZONED */
>  
> -static inline int sd_zbc_init(void)
> -{
> -	return 0;
> -}
> -
>  static inline int sd_zbc_init_disk(struct scsi_disk *sdkp)
>  {
>  	return 0;
>  }
>  
> -static inline void sd_zbc_exit(void) {}
>  static inline void sd_zbc_release_disk(struct scsi_disk *sdkp) {}
>  
>  static inline int sd_zbc_read_zones(struct scsi_disk *sdkp,
> 

Woops that looks like some leftover from development. My bad.

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>