linux-kernel - Re: [PATCH] clk: clk-atlas6: fix return value check in atlas6_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4z4QfmFxu=+8QgKz4qSSob+2K+EO5hukPjhgPYkvEuJmw@mail.gmail.com>
Date:   Wed, 15 Jul 2020 21:23:20 +1200
From:   Barry Song <baohua@...nel.org>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     Michael Turquette <mturquette@...libre.com>, sboyd@...nel.org,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: clk-atlas6: fix return value check in atlas6_clk_init()

Xu Wang <vulab@...as.ac.cn> 于2020年7月13日周一 下午3:27写道：
>
> In case of error, the function clk_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
>
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Acked-by: Barry Song <baohua@...nel.org>

> ---
>  drivers/clk/sirf/clk-atlas6.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c
> index c84d5bab7ac2..b95483bb6a5e 100644
> --- a/drivers/clk/sirf/clk-atlas6.c
> +++ b/drivers/clk/sirf/clk-atlas6.c
> @@ -135,7 +135,7 @@ static void __init atlas6_clk_init(struct device_node *np)
>
>         for (i = pll1; i < maxclk; i++) {
>                 atlas6_clks[i] = clk_register(NULL, atlas6_clk_hw_array[i]);
> -               BUG_ON(!atlas6_clks[i]);
> +               BUG_ON(IS_ERR(atlas6_clks[i]));
>         }
>         clk_register_clkdev(atlas6_clks[cpu], NULL, "cpu");
>         clk_register_clkdev(atlas6_clks[io],  NULL, "io");
> --
> 2.17.1
>