linux-kernel - RE: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 14:38:29 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Oliver O'Halloran' <oohall@...il.com>,
        Arnd Bergmann <arnd@...db.de>
CC:     Bjorn Helgaas <helgaas@...nel.org>,
        Keith Busch <kbusch@...nel.org>,
        "Paul Mackerras" <paulus@...ba.org>,
        sparclinux <sparclinux@...r.kernel.org>,
        "Toan Le" <toan@...amperecomputing.com>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        "Marek Vasut" <marek.vasut+renesas@...il.com>,
        Rob Herring <robh@...nel.org>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@....com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Russell King <linux@...linux.org.uk>,
        Ley Foon Tan <ley.foon.tan@...el.com>,
        Christoph Hellwig <hch@....de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Kevin Hilman <khilman@...libre.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Matt Turner <mattst88@...il.com>,
        "linux-kernel-mentees@...ts.linuxfoundation.org" 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Ray Jui <rjui@...adcom.com>, Jens Axboe <axboe@...com>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "bjorn@...gaas.com" <bjorn@...gaas.com>,
        "Boris Ostrovsky" <boris.ostrovsky@...cle.com>,
        Richard Henderson <rth@...ddle.net>,
        Juergen Gross <jgross@...e.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        Scott Branden <sbranden@...adcom.com>,
        Jingoo Han <jingoohan1@...il.com>,
        "Saheed O. Bolarinwa" <refactormyself@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        "David S. Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>
Subject: RE: [RFC PATCH 00/35] Move all PCIBIOS* definitions into arch/x86

From: Oliver O'Halloran
> Sent: 15 July 2020 05:19
> 
> On Wed, Jul 15, 2020 at 8:03 AM Arnd Bergmann <arnd@...db.de> wrote:
...
> > - config space accesses are very rare compared to memory
> >   space access and on the hardware side the error handling
> >   would be similar, but readl/writel don't return errors, they just
> >   access wrong registers or return 0xffffffff.
> >   arch/powerpc/kernel/eeh.c has a ton extra code written to
> >   deal with it, but no other architectures do.
> 
> TBH the EEH MMIO hooks were probably a mistake to begin with. Errors
> detected via MMIO are almost always asynchronous to the error itself
> so you usually just wind up with a misleading stack trace rather than
> any kind of useful synchronous error reporting. It seems like most
> drivers don't bother checking for 0xFFs either and rely on the
> asynchronous reporting via .error_detected() instead, so I have to
> wonder what the point is. I've been thinking of removing the MMIO
> hooks and using a background poller to check for errors on each PHB
> periodically (assuming we don't have an EEH interrupt) instead. That
> would remove the requirement for eeh_dev_check_failure() to be
> interrupt safe too, so it might even let us fix all the godawful races
> in EEH.

I've 'played' with PCIe error handling - without much success.
What might be useful is for a driver that has just read ~0u to
be able to ask 'has there been an error signalled for this device?'.

I got an error generated by doing an MMIO access that was inside
the address range forwarded to the slave, but outside any of its BARs.
(Two BARs of different sizes leaves a nice gap.)
This got reported up to the bridge nearest the slave (which supported
error handling), but not to the root bridge (which I don't think does).
ISTR a message about EEH being handled by the hardware (the machine
is up but dmesg is full of messages from a bouncing USB mouse).

With such partial error reporting useful info can still be extracted.

Of course, what actually happens on a PCIe error is that the signal
gets routed to some 'board support logic' and then passed back into
the kernel as an NMI - which then crashes the kernel!
This even happens when the PCIe link goes down after we've done a
soft-remove of the device itself!
Rather makes updating the board's FPGA without a reboot tricky.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)