linux-kernel - Re: [PATCH] dmaengine: imx-sdma: remove always true comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 20:57:32 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Fabio Estevam <festevam@...il.com>
Cc:     dmaengine@...r.kernel.org, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: imx-sdma: remove always true comparisons

Hi Fabio,

On 15-07-20, 10:16, Fabio Estevam wrote:
> Hi Vinod,
> 
> On Wed, Jul 15, 2020 at 10:01 AM Vinod Koul <vkoul@...nel.org> wrote:
> >
> > sdmac->event_id0 is of type unsigned int and hence can never be less
> > than zero. Driver compares this at couple of places with greater than or
> > equal to zero, these are always true so should be dropped
> >
> > drivers/dma/imx-sdma.c:1336:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> > drivers/dma/imx-sdma.c:1637:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
> >
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> 
> I have already fixed this problem and you have already applied my patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?h=next&id=2f57b8d57673af2c2caf8c2c7bef01be940a5c2c

My bad that I didnt run this on -next :-)

-- 
~Vinod