[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <473adfb3-c66b-aa5a-ce61-af335002b752@collabora.com>
Date: Wed, 15 Jul 2020 17:40:03 +0200
From: Enric Balletbo i Serra <enric.balletbo@...labora.com>
To: Bhanu Prakash Maiya <bhanumaiya@...omium.org>,
linux-arm-kernel@...ts.infradead.org
Cc: Lee Jones <lee.jones@...aro.org>,
Furquan Shaikh <furquan@...omium.org>,
Raul E Rangel <rrangel@...omium.org>,
Eric Peers <epeers@...gle.com>,
Duncan Laurie <dlaurie@...gle.com>,
Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>,
Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Rob Herring <robh@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devicetree@...r.kernel.org, linux-kernel@...r.Kernel.org,
Bhanu Prakash Maiya <bhanumaiya@...gle.com>
Subject: Re: [PATCH v2 2/2] dt-bindings: mfd: Add DT compatible string
"google,cros_ec_uart"
Hi bhanu,
Thank you for your patch. This patch has some style problems, please make sure
to fix and resent the patch.
On 15/7/20 10:25, Bhanu Prakash Maiya wrote:
> From: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
>
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
>
That's actually removed you should base your changes on top of
https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=46b5780688c0d825b6b8d49b267b13102bea512d
> Series-to: LKML <linux-kernel@...r.kernel.org>
> Series-cc: Raul E Rangel <rrangel@...omium.org>, Furquan Shaikh <furquan@...omium.org>, Duncan Laurie <dlaurie@...gle.com>, Eric Peers <epeers@...gle.com>, Benson Leung <bleung@...omium.org>, Enric Balletbo i Serra <enric.balletbo@...labora.com>, Guenter Roeck <groeck@...omium.org>, linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
>
I think you need to fix your patman workflow. This should be removed from here.
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...omium.org>
> Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822
The Change-Id is useless upstream, please remove it.
> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@...gle.com>
Only one signed-off per person please.
> ---
> Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> index 4860eabd0f729..ec8c5d7ecc266 100644
> --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt
> +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt
> @@ -3,7 +3,7 @@ ChromeOS Embedded Controller
> Google's ChromeOS EC is a Cortex-M device which talks to the AP and
> implements various function such as keyboard and battery charging.
>
> -The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the
> +The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the
> compatible string used depends on the interface. Each connection method has
> its own driver which connects to the top level interface-agnostic EC driver.
> Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to
> @@ -17,6 +17,10 @@ Required properties (SPI):
> - compatible: "google,cros-ec-spi"
> - reg: SPI chip select
>
> +Required properties (UART):
> +- compatible: "google,cros-ec-uart"
> +- reg: UART baudrate, flowcontrol
> +
That's odd, a reg that is mean to contain the baudrate and the flowcontrol? How?
> Required properties (RPMSG):
> - compatible: "google,cros-ec-rpmsg"
>
> @@ -72,5 +76,6 @@ spi@...b0000 {
> };
> };
>
> -
> Example for LPC is not supplied as it is not yet implemented.
> +
> +Example for UART is not supplied as it is not yet implemented.
>
Powered by blists - more mailing lists