linux-kernel - Re: [PATCH V1 2/2] i2c: iproc: add slave pec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 21:26:24 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Cc:     Wolfram Sang <wsa@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Lori Hikichi <lori.hikichi@...adcom.com>,
        Robert Richter <rrichter@...vell.com>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V1 2/2] i2c: iproc: add slave pec support

On Thu, Jul 16, 2020 at 10:49:14PM +0530, Rayagonda Kokatanur wrote:
> On Thu, Jul 16, 2020 at 3:44 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Thu, Jul 16, 2020 at 11:14 AM Rayagonda Kokatanur
> > <rayagonda.kokatanur@...adcom.com> wrote:

...
> > > -#define S_RX_PEC_ERR_SHIFT           29
> > > +#define S_RX_PEC_ERR_SHIFT           28

> > This needs to be explained in the commit message, in particular why
> > this change makes no regression.
> 
> I didn't get what do you mean by "no regression", please elaborate.

The definition above has been changed. The point is you have to point out in
the commit message why it's okay and makes no regression.
For example, "..._SHIFT is changed to ... according to documentation. Since
there was no user of it no regression will be made." Provide proper text, b/c
I have no idea what is exactly the reason of the change and if it's indeed used
to have no users.

...

> > > +                               ret = bcm_iproc_smbus_check_slave_pec(iproc_i2c,
> > > +                                                                     val);
> >
> > One line looks better.
> 
> Yes, but to have 80 char per line, I have to do this.

We have more, but even if you stick with 80 the above is harder to get than if it is one line.

-- 
With Best Regards,
Andy Shevchenko