linux-kernel - Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200716195010.GV10769@hirez.programming.kicks-ass.net>
Date:   Thu, 16 Jul 2020 21:50:10 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Fenghua Yu <fenghua.yu@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Tony Luck <tony.luck@...el.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        x86 <x86@...nel.org>, linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire
 Rapids

On Thu, Jul 16, 2020 at 12:37:00PM -0700, Fenghua Yu wrote:
> Hi, Thomas, Boris, Ingo,
> 
> On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
> > Add Sapphire Rapids processor to CPU list to enumerate split lock
> > feature.
> > 
> > Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> > Reviewed-by: Tony Luck <tony.luck@...el.com>
> > ---
> >  arch/x86/kernel/cpu/intel.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> > index c25a67a34bd3..dca069ad6671 100644
> > --- a/arch/x86/kernel/cpu/intel.c
> > +++ b/arch/x86/kernel/cpu/intel.c
> > @@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {
> >  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,	1),
> >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L,		1),
> >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,		1),
> > +	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	1),
> >  	{}
> >  };
> 
> Any comment on this patch?

The only comment I have is that us needing it is ludicrous :/ What's the
bloody point of having it 'enumerated' if you then still have to use FMS
lists.

There's nowhere near enough cursing in the comment that goes with that
list.