linux-kernel - Re: [PATCH] ASoC: soc-jack: calling snd_soc_jack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200716222958.GA25428@sirena.org.uk>
Date:   Thu, 16 Jul 2020 23:29:58 +0100
From:   Mark Brown <broonie@...nel.org>
To:     mnlife qiao <mnlife.qiao@...il.com>
Cc:     lgirdwood@...il.com, Jaroslav Kysela <perex@...ex.cz>,
        open list <linux-kernel@...r.kernel.org>,
        alsa-devel@...a-project.org, mnlife <mnlife@...mail.com>
Subject: Re: [PATCH] ASoC: soc-jack: calling snd_soc_jack_report causes a
 null pointer access

On Wed, Jul 15, 2020 at 08:24:04AM +0800, mnlife qiao wrote:
> When snd_soc_card_jack_new is not called or the call fails,
> calling this function causes a null pointer access

> --- a/sound/soc/soc-jack.c
> +++ b/sound/soc/soc-jack.c
> @@ -44,7 +44,7 @@ void snd_soc_jack_report(struct snd_soc_jack *jack, int status, int mask)
> 	unsigned int sync = 0;
> 	int enable;
> 
> -	if (!jack)
> +	if (!jack || !jack->jack)
> 		return;

I'm afraid this still won't apply - there's a text/html version of the
patch, in the text portion tabs have been converted into spaces and it
appears some other issues that mean git am can't understand it.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)