linux-kernel - Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sgds2ixs.wl-kuninori.morimoto.gx@renesas.com>
Date:   16 Jul 2020 13:17:34 +0900
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Shengjiu Wang <shengjiu.wang@....com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, ranjani.sridharan@...ux.intel.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap


Hi Shengjiu

> Add missed return for snd_soc_pcm_component_mmap, otherwise it always
> return -EINVAL.
> 
> Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---

Oops, indeed.
Thank you for the patch.

But it seems these functions are also missing "return"
	snd_soc_pcm_component_new()
	snd_soc_pcm_component_sync_stop()

Can you please care these, too ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto